staging: r8188eu: remove rtw_hal_c2h_id_filter_ccx function
authorPhillip Potter <phil@philpotter.co.uk>
Mon, 6 Sep 2021 01:01:05 +0000 (02:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Sep 2021 06:49:49 +0000 (08:49 +0200)
commit22bf044b03698e36d9aaee3738d27a2b1bb204e2
treeb47118e1768519811b8c234584e42854ea57e87d
parent6778b4bc3434dcb3a364429c8bf6e342bf2516a7
staging: r8188eu: remove rtw_hal_c2h_id_filter_ccx function

Remove rtw_hal_c2h_id_filter_ccx from hal/hal_intf.c and its one caller
from core/rtw_cmd.c. This function is a wrapper function which returns
the c2h_id_filter_ccx function pointer of struct hal_ops unconditionally.
As this function pointer is never set, and the function call's return
value is subsequently called inside an if condition, this could lead to
an attempt to deference a NULL pointer, which would crash the driver.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210906010106.898-14-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_cmd.c
drivers/staging/r8188eu/hal/hal_intf.c
drivers/staging/r8188eu/include/hal_intf.h