virtio-rng: make device ready before making request
authorJason Wang <jasowang@redhat.com>
Wed, 8 Jun 2022 06:14:22 +0000 (14:14 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 8 Jun 2022 12:56:03 +0000 (08:56 -0400)
commit228432551bd8783211e494ab35f42a4344580502
treef403756902a5549b9838d4e7b0e57c428b630ab0
parentf2906aa863381afb0015a9eb7fefad885d4e5a56
virtio-rng: make device ready before making request

Current virtio-rng does a entropy request before DRIVER_OK, this
violates the spec:

virtio spec requires that all drivers set DRIVER_OK
before using devices.

Further, kernel will ignore the interrupt after commit
8b4ec69d7e09 ("virtio: harden vring IRQ").

Fixing this by making device ready before the request.

Cc: stable@vger.kernel.org
Fixes: 8b4ec69d7e09 ("virtio: harden vring IRQ")
Fixes: f7f510ec1957 ("virtio: An entropy device, as suggested by hpa.")
Reported-and-tested-by: syzbot+5b59d6d459306a556f54@syzkaller.appspotmail.com
Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20220608061422.38437-1-jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
drivers/char/hw_random/virtio-rng.c