bnxt_en: fix error handling when flashing from file
authorEdwin Peer <edwin.peer@broadcom.com>
Mon, 2 Mar 2020 03:07:18 +0000 (22:07 -0500)
committerDavid S. Miller <davem@davemloft.net>
Mon, 2 Mar 2020 03:15:27 +0000 (19:15 -0800)
commit22630e28f9c2b55abd217869cc0696def89f2284
treedc2f909f8ec4f0c1fe6f60b1fdc082519fc8b842
parenta9b952d267e59a3b405e644930f46d252cea7122
bnxt_en: fix error handling when flashing from file

After bnxt_hwrm_do_send_message() was updated to return standard error
codes in a recent commit, a regression in bnxt_flash_package_from_file()
was introduced.  The return value does not properly reflect all
possible firmware errors when calling firmware to flash the package.

Fix it by consolidating all errors in one local variable rc instead
of having 2 variables for different errors.

Fixes: d4f1420d3656 ("bnxt_en: Convert error code in firmware message response to standard code.")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c