Fix duplicate suggestions after an ambiguous command
authorRaphael Isemann <teemperor@gmail.com>
Thu, 26 Jul 2018 17:14:18 +0000 (17:14 +0000)
committerRaphael Isemann <teemperor@gmail.com>
Thu, 26 Jul 2018 17:14:18 +0000 (17:14 +0000)
commit223d921c6a17c037ba2d5276bc70e916df63827f
treec7b6e5acf4e5a6e308f2e9235634340c14fc332a
parent279621fbf0ab3758784bf79139711ae3424f69ec
Fix duplicate suggestions after an ambiguous command

Summary:
So far lldb is printing this when it finds an ambiguous command:
```
(lldb) g
Ambiguous command 'g'. Possible matches:
        gdb-remote
        gui
        gdb-remote
        gui
```
The duplicates come from the fact that we call the same query twice with the same parameters
and add it to the same list. This patch just removes the second query call to `GetCommandObject`.

As `GetCommandObject` is const and the name parameter is also not modified, this shouldn't break
anything else. I didn't merge the remaining if statement into the else as I think otherwise the
`if obj==nullptr do X else Y` pattern in there becomes hard to recognize.

Reviewers: davide

Reviewed By: davide

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D49866

llvm-svn: 338043
lldb/packages/Python/lldbsuite/test/functionalities/wrong_commands/TestWrongCommands.py
lldb/source/Interpreter/CommandInterpreter.cpp