arm64: mmap: Ensure file offset is treated as unsigned
authorBoyang Zhou <zhouby_cn@126.com>
Mon, 29 Apr 2019 14:27:19 +0000 (15:27 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 May 2019 05:37:35 +0000 (07:37 +0200)
commit222abad906ba7e4727270930c681173d7d4769aa
tree3cd5d15935c18778989bb00d6671ee1f74c529f9
parent592127e9c1bbc14795292a273faa006d805c7fe8
arm64: mmap: Ensure file offset is treated as unsigned

commit f08cae2f28db24d95be5204046b60618d8de4ddc upstream.

The file offset argument to the arm64 sys_mmap() implementation is
scaled from bytes to pages by shifting right by PAGE_SHIFT.
Unfortunately, the offset is passed in as a signed 'off_t' type and
therefore large offsets (i.e. with the top bit set) are incorrectly
sign-extended by the shift. This has been observed to cause false mmap()
failures when mapping GPU doorbells on an arm64 server part.

Change the type of the file offset argument to sys_mmap() from 'off_t'
to 'unsigned long' so that the shifting scales the value as expected.

Cc: <stable@vger.kernel.org>
Signed-off-by: Boyang Zhou <zhouby_cn@126.com>
[will: rewrote commit message]
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm64/kernel/sys.c