drm/vgem: fix use-after-free when drm_gem_handle_create() fails
authorEric Biggers <ebiggers@google.com>
Tue, 26 Feb 2019 21:44:51 +0000 (13:44 -0800)
committerMaxime Ripard <maxime.ripard@bootlin.com>
Mon, 18 Mar 2019 07:45:57 +0000 (08:45 +0100)
commit21d2b122732318b48c10b7262e15595ce54511d3
treef741412c4ad39988246ff8c406e7dcfb8051d5f7
parent9e98c678c2d6ae3a17cb2de55d17f69dddaa231b
drm/vgem: fix use-after-free when drm_gem_handle_create() fails

If drm_gem_handle_create() fails in vgem_gem_create(), then the
drm_vgem_gem_object is freed twice: once when the reference is dropped
by drm_gem_object_put_unlocked(), and again by __vgem_gem_destroy().

This was hit by syzkaller using fault injection.

Fix it by skipping the second free.

Reported-by: syzbot+e73f2fb5ed5a5df36d33@syzkaller.appspotmail.com
Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces")
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Laura Abbott <labbott@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Laura Abbott <labbott@redhat.com>
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190226214451.195123-1-ebiggers@kernel.org
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
drivers/gpu/drm/vgem/vgem_drv.c