timerqueue: Use rb_entry_safe() in timerqueue_getnext()
authorBarnabás Pőcze <pobrn@protonmail.com>
Mon, 14 Nov 2022 19:54:23 +0000 (19:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:31:56 +0000 (13:31 +0100)
commit21bec0ebb854e358c6c3be55af553131808323c3
tree70259f8ba83a6540553147cb2f5b9c939207b589
parent790c52369e5dab00f51dfed0d4a4ba8c0b3bf1ba
timerqueue: Use rb_entry_safe() in timerqueue_getnext()

[ Upstream commit 2f117484329b233455ee278f2d9b0a4356835060 ]

When `timerqueue_getnext()` is called on an empty timer queue, it will
use `rb_entry()` on a NULL pointer, which is invalid. Fix that by using
`rb_entry_safe()` which handles NULL pointers.

This has not caused any issues so far because the offset of the `rb_node`
member in `timerqueue_node` is 0, so `rb_entry()` is essentially a no-op.

Fixes: 511885d7061e ("lib/timerqueue: Rely on rbtree semantics for next timer")
Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20221114195421.342929-1-pobrn@protonmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/timerqueue.h