perf tools: Factor out buildid reading and make it implicit in dso__load
authorDave Martin <dave.martin@linaro.org>
Fri, 30 Jul 2010 12:08:08 +0000 (09:08 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 30 Jul 2010 12:53:30 +0000 (09:53 -0300)
commit21916c380d93ab59d6d07ee198fb31c8f1338e26
tree8d7d491ea6549b74144efa5ba63c4240f84a874a
parent6e406257b3794009e3b7a6d48b54beb547719565
perf tools: Factor out buildid reading and make it implicit in dso__load

If we have a buildid, then we never want to load an image which has no buildid,
or which has a different buildid, so it makes sense for the check to be built
into dso__load and not done separately.  This is fine for old distros which
don't use buildid at all since we do no check in that case.

This refactoring also alleviates some subtle race condition issues by not
opening ELF images twice to check the buildid and then load the symbols, which
could lead to weirdness if an image is replaced under our feet.

Signed-off-by: Dave Martin <dave.martin@linaro.org>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/symbol.c