[analyzer] Don't delete TaintConfig copy constructor
authorAlex Langford <apl@fb.com>
Wed, 14 Aug 2019 01:09:07 +0000 (01:09 +0000)
committerAlex Langford <apl@fb.com>
Wed, 14 Aug 2019 01:09:07 +0000 (01:09 +0000)
commit21872bc9bf374db7f7f340758ac9bf262b892a53
tree2fc20c1c3b3e1c71f66dd5efd55c4fc506199ea8
parent5ee4d7a859dc2029adb3ff5a30aaed6b0fb816af
[analyzer] Don't delete TaintConfig copy constructor

Summary:
Explicitly deleting the copy constructor makes compiling the function
`ento::registerGenericTaintChecker` difficult with some compilers. When we
construct an `llvm::Optional<TaintConfig>`, the optional is constructed with a
const TaintConfig reference which it then uses to invoke the deleted TaintConfig
copy constructor.

I've observered this failing with clang 3.8 on Ubuntu 16.04.

Reviewers: compnerd, Szelethus, boga95, NoQ, alexshap

Subscribers: xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, llvm-commits, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D66192

llvm-svn: 368779
clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp