scsi: make scsi_eh_scmd_add() always succeed
authorHannes Reinecke <hare@suse.de>
Thu, 6 Apr 2017 13:36:34 +0000 (15:36 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 6 Apr 2017 17:07:33 +0000 (13:07 -0400)
commit2171b6d08bf8c2b826922b94e24ba36b00cb78b3
treee0c8a2c62559b1385887550598f12a1570d1e174
parent8e8c9d01c5ea33e0d21f13264a9caeed255526d1
scsi: make scsi_eh_scmd_add() always succeed

scsi_eh_scmd_add() currently only will fail if no
error handler thread is started (which will never be the
case) or if the state machine encounters an illegal transition.

But if we're encountering an invalid state transition
chances is we cannot fixup things with the error handler.
So better add a WARN_ON for illegal host states and
make scsi_dh_scmd_add() a void function.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_error.c
drivers/scsi/scsi_lib.c
drivers/scsi/scsi_priv.h