xfrm6: call kfree_skb when skb is toobig
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Fri, 31 Aug 2018 11:38:49 +0000 (08:38 -0300)
committerSteffen Klassert <steffen.klassert@secunet.com>
Mon, 3 Sep 2018 05:37:57 +0000 (07:37 +0200)
commit215ab0f021c9fea3c18b75e7d522400ee6a49990
tree207c34d777bb1e7d24f658929e96b7a51d0cfed7
parent07bf7908950a8b14e81aa1807e3c667eab39287a
xfrm6: call kfree_skb when skb is toobig

After commit d6990976af7c5d8f55903bfb4289b6fb030bf754 ("vti6: fix PMTU caching
and reporting on xmit"), some too big skbs might be potentially passed down to
__xfrm6_output, causing it to fail to transmit but not free the skb, causing a
leak of skb, and consequentially a leak of dst references.

After running pmtu.sh, that shows as failure to unregister devices in a namespace:

[  311.397671] unregister_netdevice: waiting for veth_b to become free. Usage count = 1

The fix is to call kfree_skb in case of transmit failures.

Fixes: dd767856a36e ("xfrm6: Don't call icmpv6_send on local error")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/ipv6/xfrm6_output.c