[lit] Make internal diff work in pipelines
authorJoel E. Denny <jdenny.ornl@gmail.com>
Mon, 16 Sep 2019 21:22:29 +0000 (21:22 +0000)
committerJoel E. Denny <jdenny.ornl@gmail.com>
Mon, 16 Sep 2019 21:22:29 +0000 (21:22 +0000)
commit2152ae985c28ff10e6f4d4b674ae9b144ecb04c0
tree3fcdd09272327c69b44f23af971e627540fc57a9
parentc1c519d2f1a66dd2eeaa4c321d8d7b50f623eb71
[lit] Make internal diff work in pipelines

When using lit's internal shell, RUN lines like the following
accidentally execute an external `diff` instead of lit's internal
`diff`:

```
 # RUN: program | diff file -
 # RUN: not diff file1 file2 | FileCheck %s
```

Such cases exist now, in `clang/test/Analysis` for example.  We are
preparing patches to ensure lit's internal `diff` is called in such
cases, which will then fail because lit's internal `diff` cannot
currently be used in pipelines and doesn't recognize `-` as a
command-line option.

To enable pipelines, this patch moves lit's `diff` implementation into
an out-of-process script, similar to lit's `cat` implementation.  A
follow-up patch will implement `-` to mean stdin.

Reviewed By: probinson, stella.stamenova

Differential Revision: https://reviews.llvm.org/D66574

llvm-svn: 372035
llvm/utils/lit/lit/TestRunner.py
llvm/utils/lit/lit/builtin_commands/diff.py [new file with mode: 0644]
llvm/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt [deleted file]
llvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt [new file with mode: 0644]
llvm/utils/lit/tests/shtest-shell.py