devlink: protect devlink dump by the instance lock
authorJakub Kicinski <kuba@kernel.org>
Fri, 16 Dec 2022 04:41:22 +0000 (20:41 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 17 Dec 2022 05:16:28 +0000 (21:16 -0800)
commit214964a13ab56a9757d146b79b468a7ca190fbfb
tree6f6e58e776bc60eb33ffb20d954608589b23e2fe
parent078838f5b9c9203e94d7724f997392ea8012ea6a
devlink: protect devlink dump by the instance lock

Take the instance lock around devlink_nl_fill() when dumping,
doit takes it already.

We are only dumping basic info so in the worst case we were risking
data races around the reload statistics. Until the big devlink mutex
was removed all relevant code was protected by it, so the missing
instance lock was not exposed.

Fixes: d3efc2a6a6d8 ("net: devlink: remove devlink_mutex")
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20221216044122.1863550-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/devlink.c