ALSA: hda: cs35l56: Fix missing RESET GPIO if _SUB is missing
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Thu, 14 Sep 2023 15:25:25 +0000 (16:25 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 15 Sep 2023 08:31:04 +0000 (10:31 +0200)
commit21484e43b936c4f323d232c6a71c1f47a6af3278
tree023e921342a50e8f849c462aaa48b98a6b9555a8
parent057a28ef93bdbe84326d34cdb5543afdaab49fe1
ALSA: hda: cs35l56: Fix missing RESET GPIO if _SUB is missing

In cs35l56_hda_read_acpi() do not return if ACPI _SUB is missing.

A missing _SUB means that the driver cannot load a system-specific
firmware, because the firmware is identified by the _SUB. But it can
fallback to a generic firmware. Unfortunately this was being handled
by immediately returning 0, which would skip the remaining ACPI
configuration in cs35l56_hda_read_acpi() and so it would not get the
RESET GPIO.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Link: https://lore.kernel.org/r/20230914152525.20829-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l56_hda.c