x86/platform/uv: Refactor code using deprecated strncpy() interface to use strscpy()
authorJustin Stitt <justinstitt@google.com>
Tue, 22 Aug 2023 22:05:30 +0000 (22:05 +0000)
committerIngo Molnar <mingo@kernel.org>
Thu, 24 Aug 2023 19:22:50 +0000 (21:22 +0200)
commit212f07a21622cbd4bb271b558b2d3ae0652e9875
treebb7a0a996146819d7406a281bff87135e3671f61
parent4108d141bfd04cf7b2bbf96e899ee5392f62e8a2
x86/platform/uv: Refactor code using deprecated strncpy() interface to use strscpy()

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on its destination buffer argument which is
_not_ the case for `strncpy`!

In this case, it means we can drop the `...-1` from:
|       strncpy(to, from, len-1);

as well as remove the comment mentioning NUL-termination as `strscpy`
implicitly grants us this behavior.

There should be no functional change as I don't believe the padding from
`strncpy` is needed here. If it turns out that the padding is necessary
we should use `strscpy_pad` as a direct replacement.

Signed-off-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Dimitri Sivanich <sivanich@hpe.com>
Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Link: https://lore.kernel.org/r/20230822-strncpy-arch-x86-kernel-apic-x2apic_uv_x-v1-1-91d681d0b3f3@google.com
arch/x86/kernel/apic/x2apic_uv_x.c