Fix gdb_xml_debug/gdb_xml_error ATTRIBUTE_PRINTF use
authorPedro Alves <palves@redhat.com>
Mon, 27 Mar 2017 11:28:03 +0000 (12:28 +0100)
committerPedro Alves <palves@redhat.com>
Mon, 27 Mar 2017 11:28:03 +0000 (12:28 +0100)
commit210477268d4ac5cad937e811888a5c932206794c
tree70565a15b6b77a2cfe1d9c028d2b2f33c3b0544d
parent9b7539374617a94c2d646f49e1bbfc954b11891d
Fix gdb_xml_debug/gdb_xml_error ATTRIBUTE_PRINTF use

The declarations of gdb_xml_debug and gdb_xml_error are passing "0" as
"first-to-check" argument to ATTRIBUTE_PRINTF, as if they were va_args
functions.  Consequently, the arguments to gdb_xml_debug /
gdb_xml_error aren't being checked against the format strings.

With that fixed, a couple obvious bugs are exposed, both fixed by this
commit.

gdb/ChangeLog:
2017-03-27  Pedro Alves  <palves@redhat.com>

* xml-support.h (gdb_xml_debug): Pass a "first-to-check" argument
to ATTRIBUTE_PRINTF.
* solib-target.c (library_list_start_list): Print "string" not
"version".
* xml-tdesc.c (tdesc_start_field): Pass "field_name" to
gdb_xml_error call.
gdb/ChangeLog
gdb/solib-target.c
gdb/xml-support.h
gdb/xml-tdesc.c