libbpf: Revert bpf_helper_defs.h inclusion regression
authorAndrii Nakryiko <andriin@fb.com>
Fri, 17 Jan 2020 00:41:02 +0000 (16:41 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 17 Jan 2020 04:01:33 +0000 (20:01 -0800)
commit20f21d98cf12b8ecd69e8defc93fae9e3b353b13
tree7ad830cc914d26d254a5c6830609c2cca9c33c01
parent35697c12d7ffd31a56d3c9604066a166b75d0169
libbpf: Revert bpf_helper_defs.h inclusion regression

Revert bpf_helpers.h's change to include auto-generated bpf_helper_defs.h
through <> instead of "", which causes it to be searched in include path. This
can break existing applications that don't have their include path pointing
directly to where libbpf installs its headers.

There is ongoing work to make all (not just bpf_helper_defs.h) includes more
consistent across libbpf and its consumers, but this unbreaks user code as is
right now without any regressions. Selftests still behave sub-optimally
(taking bpf_helper_defs.h from libbpf's source directory, if it's present
there), which will be fixed in subsequent patches.

Fixes: 6910d7d3867a ("selftests/bpf: Ensure bpf_helper_defs.h are taken from selftests dir")
Reported-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200117004103.148068-1-andriin@fb.com
tools/lib/bpf/bpf_helpers.h