scsi: sd: Keep disk read-only when re-reading partition
authorJeremy Cline <jeremy@jcline.org>
Tue, 6 Mar 2018 21:47:32 +0000 (21:47 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 7 Mar 2018 03:07:49 +0000 (22:07 -0500)
commit20bd1d026aacc5399464f8328f305985c493cde3
treec095e7185a535448eb9f0257b16c77bf279a9d04
parent6a2cf8d3663e13e19af636c2a8d92e766261dc45
scsi: sd: Keep disk read-only when re-reading partition

If the read-only flag is true on a SCSI disk, re-reading the partition
table sets the flag back to false.

To observe this bug, you can run:

1. blockdev --setro /dev/sda
2. blockdev --rereadpt /dev/sda
3. blockdev --getro /dev/sda

This commit reads the disk's old state and combines it with the device
disk-reported state rather than unconditionally marking it as RW.

Reported-by: Li Ning <lining916740672@icloud.com>
Signed-off-by: Jeremy Cline <jeremy@jcline.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c