clk: Initialize the clk_rate_request even if clk_core is NULL
authorMaxime Ripard <maxime@cerno.tech>
Tue, 18 Oct 2022 13:52:57 +0000 (15:52 +0200)
committerStephen Boyd <sboyd@kernel.org>
Fri, 28 Oct 2022 00:08:29 +0000 (17:08 -0700)
commit2079d029387adfc0cc123f01a6fcf9eb6540ee4d
treed975f1f88b7eff2004a5a90e0f0c5ea2391a9ccb
parent08a32902a56e1670850fe5d518d8203e9ce354b8
clk: Initialize the clk_rate_request even if clk_core is NULL

Since commit c35e84b09776 ("clk: Introduce clk_hw_init_rate_request()"),
users that used to initialize their clk_rate_request by initializing
their local structure now rely on clk_hw_init_rate_request().

This function is backed by clk_core_init_rate_req(), which will skip the
initialization if either the pointer to struct clk_core or to struct
clk_rate_request are NULL.

However, the core->parent pointer might be NULL because the clock is
orphan, and we will thus end up with our local struct clk_rate_request
left untouched.

And since clk_hw_init_rate_request() doesn't return an error, we will
then call a determine_rate variant with that unitialized structure.

In order to avoid this, let's clear our clk_rate_request if the pointer
to it is valid but the pointer to struct clk_core isn't.

Fixes: c35e84b09776 ("clk: Introduce clk_hw_init_rate_request()")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20221018-clk-range-checks-fixes-v1-2-f3ef80518140@cerno.tech
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk.c