[mlir][sparse] Improving ExecutionEngine/SparseTensorUtils.h
authorwren romano <2998727+wrengr@users.noreply.github.com>
Thu, 26 May 2022 19:31:58 +0000 (12:31 -0700)
committerwren romano <2998727+wrengr@users.noreply.github.com>
Fri, 27 May 2022 00:22:08 +0000 (17:22 -0700)
commit2046e11ac493818ef782d71a841275c10f3834c5
tree50cf463adb47f8043d8b54eedc99f46f45b40f9b
parentedcd06ba8b4123af83274845316b037b3864f8cb
[mlir][sparse] Improving ExecutionEngine/SparseTensorUtils.h

This change makes the public API of SparseTensorUtils.cpp explicit, whereas before the publicity of these functions was only implicit.  Implicit publicity is sufficient for mlir-opt to generate calls to these functions, but it's not enough to enable C/C++ code to call them directly in the usual way (i.e., without going through codegen).  Thus, leaving the publicity implicit prevents development of other tools (e.g., microbenchmarks).

In addition this change also marks the functions MLIR_CRUNNERUTILS_EXPORT, which is required by the JIT under certain configurations (albeit not for anything in our test suite).

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D126105
mlir/include/mlir/ExecutionEngine/SparseTensorUtils.h
mlir/lib/ExecutionEngine/SparseTensorUtils.cpp
utils/bazel/llvm-project-overlay/mlir/BUILD.bazel