xfs: Don't log uninitialised fields in inode structures
authorDave Chinner <dchinner@redhat.com>
Mon, 9 Oct 2017 18:37:22 +0000 (11:37 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Wed, 11 Oct 2017 17:21:06 +0000 (10:21 -0700)
commit20413e37d71befd02b5846acdaf5e2564dd1c38e
treee82e3b0d39a6f9322af59f3ed8146f9cd00a6d9e
parente12199f85d0ad1b04ce6c425ad93cd847fe930bb
xfs: Don't log uninitialised fields in inode structures

Prevent kmemcheck from throwing warnings about reading uninitialised
memory when formatting inodes into the incore log buffer. There are
several issues here - we don't always log all the fields in the
inode log format item, and we never log the inode the
di_next_unlinked field.

In the case of the inode log format item, this is exacerbated
by the old xfs_inode_log_format structure padding issue. Hence make
the padded, 64 bit aligned version of the structure the one we always
use for formatting the log and get rid of the 64 bit variant. This
means we'll always log the 64-bit version and so recovery only needs
to convert from the unpadded 32 bit version from older 32 bit
kernels.

Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Tested-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/libxfs/xfs_log_format.h
fs/xfs/xfs_inode_item.c
fs/xfs/xfs_ondisk.h