rtc: rk808: fix possible race condition
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 21 Feb 2018 10:57:05 +0000 (11:57 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 17 Mar 2018 13:20:42 +0000 (14:20 +0100)
commit201fac95e799c3d0304ec724d555e1251b9f6e84
tree1b6758467df034e9207fe9a083faabaccb3bda5e
parent4cda172bc338abf770dcdbcf61049ef0d76b17fc
rtc: rk808: fix possible race condition

The probe function is not allowed to fail after registering the RTC because
the following may happen:

CPU0:                                CPU1:
sys_load_module()
 do_init_module()
  do_one_initcall()
   cmos_do_probe()
    rtc_device_register()
     __register_chrdev()
     cdev->owner = struct module*
                                     open("/dev/rtc0")
    rtc_device_unregister()
  module_put()
  free_module()
   module_free(mod->module_core)
   /* struct module *module is now
      freed */
                                      chrdev_open()
                                       spin_lock(cdev_lock)
                                       cdev_get()
                                        try_module_get()
                                         module_is_live()
                                         /* dereferences already
                                            freed struct module* */

Switch to devm_rtc_allocate_device/rtc_register_device to register the rtc
as late as possible.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-rk808.c