[lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties...
authorAlex Langford <alangford@apple.com>
Sat, 24 Jun 2023 00:27:09 +0000 (17:27 -0700)
committerAlex Langford <alangford@apple.com>
Mon, 26 Jun 2023 18:06:29 +0000 (11:06 -0700)
commit2014572d9a6839745a920ec19ebfa73814548061
treef85d3b0ecc3b5575514fdda60f46529d29ce8a24
parentf2596b754c2f286cc4df2feff27b3e14a88d4f7b
[lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

I removed ConstString from OptionValueProperties in 643ba926c1f6, but
there are a few call sites that still create a ConstString as an
argument. I did not catch these initially because ConstString has an
implicit conversion method to StringRef.

Differential Revision: https://reviews.llvm.org/D153673
lldb/source/Core/Debugger.cpp
lldb/source/Core/PluginManager.cpp
lldb/source/Target/Process.cpp
lldb/source/Target/Target.cpp
lldb/unittests/Interpreter/TestOptionValue.cpp