media: vim2m: fix two double-free issues
authorKefeng Wang <wangkefeng.wang@huawei.com>
Mon, 13 May 2019 07:18:29 +0000 (03:18 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 28 May 2019 16:49:42 +0000 (12:49 -0400)
commit20059cbbf981ca954be56f7963ae494d18e2dda1
tree0bebf1aee0d0fca59c04cada4ed6e5d5354f8685
parentdebb0dd644ce4f304240b37faa360c7cc0b89d7c
media: vim2m: fix two double-free issues

vim2m_device_release() will be called by video_unregister_device() to release
various objects.

There are two double-free issue,
1. dev->m2m_dev will be freed twice in error_m2m path/vim2m_device_release
2. the error_v4l2 and error_free path in vim2m_probe() will release
   same objects, since vim2m_device_release has done.

Fixes: ea6c7e34f3b2 ("media: vim2m: replace devm_kzalloc by kzalloc")

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/vim2m.c