[perf-training] Check extension in findFilesWithExtension
authorAmir Ayupov <aaupov@fb.com>
Tue, 10 Jan 2023 02:07:26 +0000 (18:07 -0800)
committerAmir Ayupov <aaupov@fb.com>
Tue, 10 Jan 2023 19:46:51 +0000 (11:46 -0800)
commit1fbbf92e4fda3c7a3be1c02e1f7240135557846d
tree6e6fcc17e9086bf9a53ed49d7d13e883b6e83224
parent6454391b3111993f277fb2570d28f59699b7dae2
[perf-training] Check extension in findFilesWithExtension

`findFilesWithExtension` helper checks for `endswith(extension)` instead of
exactly matching the file extension. This causes it to match unrelated files,
for example, `.profdata` files while matching `.fdata` files:

http://157.230.108.44:8011/#/builders/56/builds/247
```
Merging data from /worker/worker/bolt-x86_64-ubuntu-clang-bolt-gcc/build/tools/clang/prof.fdata.1124569.fdata...
Merging data from /worker/worker/bolt-x86_64-ubuntu-clang-bolt-gcc/build/tools/clang/test/Frontend/Output/optimization-remark-with-hotness-new-pm.c.tmp.profdata...
```

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D141342
clang/utils/perf-training/perf-helper.py