net: octeontx2: Fix the confusion in buffer alloc failure path
authorKevin Hao <haokexin@gmail.com>
Tue, 9 Feb 2021 10:15:16 +0000 (18:15 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 10 Feb 2021 23:16:35 +0000 (15:16 -0800)
commit1fb3ca767529e94efbd770048163a00eba644c1c
tree4e1d6c4bbaf23564b1e44991faeb9ffd392aa855
parentd816f2a9cb5a4e5c850f94eeb6134abec07f006d
net: octeontx2: Fix the confusion in buffer alloc failure path

Pavel pointed that the return of dma_addr_t in
otx2_alloc_rbuf/__otx2_alloc_rbuf() seem suspicious because a negative
error code may be returned in some cases. For a dma_addr_t, the error
code such as -ENOMEM does seem a valid value, so we can't judge if the
buffer allocation fail or not based on that value. Add a parameter for
otx2_alloc_rbuf/__otx2_alloc_rbuf() to store the dma address and make
the return value to indicate if the buffer allocation really fail or
not.

Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Kevin Hao <haokexin@gmail.com>
Tested-by: Subbaraya Sundeep <sbhatta@marvell.com>
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c