staging: vme_user: Fix possible UAF in tsi148_dma_list_add
authorGaosheng Cui <cuigaosheng1@huawei.com>
Thu, 17 Nov 2022 03:59:14 +0000 (11:59 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:14:27 +0000 (13:14 +0100)
commit1f5661388f43df3ac106ce93e67d8d22b16a78ff
treed5eb20cf3a5336b1ae3c38e87e35cb31cf09323c
parenta3c4bc261605fc8675760e909095c2ebd69386e8
staging: vme_user: Fix possible UAF in tsi148_dma_list_add

[ Upstream commit 357057ee55d3c99a5de5abe8150f7bca04f8e53b ]

Smatch report warning as follows:

drivers/staging/vme_user/vme_tsi148.c:1757 tsi148_dma_list_add() warn:
  '&entry->list' not removed from list

In tsi148_dma_list_add(), the error path "goto err_dma" will not
remove entry->list from list->entries, but entry will be freed,
then list traversal may cause UAF.

Fix by removeing it from list->entries before free().

Fixes: b2383c90a9d6 ("vme: tsi148: fix first DMA item mapping")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Link: https://lore.kernel.org/r/20221117035914.2954454-1-cuigaosheng1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/vme/bridges/vme_tsi148.c