udev: never ask libblkid for detecting superblocks with bad checksums (#6215)
authorLennart Poettering <lennart@poettering.net>
Wed, 28 Jun 2017 17:27:40 +0000 (19:27 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 28 Jun 2017 17:27:40 +0000 (13:27 -0400)
commit1f47f5504c3ecf62afc6511a48886232f39431ab
treeddae9b598182fcbb0f03e1f75df8dccbe71a6af8
parentcd2dfc6faea2a1e2370ae52460247bb6c8c553b1
udev: never ask libblkid for detecting superblocks with bad checksums (#6215)

Previously, we'd ask liblkid to also tell us about recognized
superblocks with bad checksums. We'd then log about them and ignore
them. This however created ambuigity problems, see #6110: the
BLKID_SUBLKS_BADCSUM is not as innocent as it appears.

This patch drops bad checksum handling and we ignore all such superblocks
entirely again, as it was the status quo ante
d47f6ca5f9b7a0b400d8bdb050151a0284fb4bdb (where this was snuck in).

Ideally, libblkid would be changed to avoid this ambiguity problems for
bad checksums, but that's not going to happen any time soon, according
to @karelzak.

Fixes: #6110
src/udev/udev-builtin-blkid.c