Bluetooth: btmrvl_main: Replace GFP_ATOMIC with GFP_KERNEL in btmrvl_send_sync_cmd
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 26 Jan 2018 15:57:01 +0000 (23:57 +0800)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 7 Feb 2018 08:48:56 +0000 (09:48 +0100)
commit1ebbf046273e50cf3cbf2ec13d520dc74ab454d4
treeaec737a39b0b5515a29dd5563ea99ad6a2aadce8
parent688d6240e0646a56ff8bdffb2310dcdeca354814
Bluetooth: btmrvl_main: Replace GFP_ATOMIC with GFP_KERNEL in btmrvl_send_sync_cmd

After checking all possible call chains to btmrvl_send_sync_cmd(),
my tool finds that this function is never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
And it calls wait_event_interruptible_timeout() after bt_skb_alloc(),
so it indicates that btmrvl_send_sync_cmd()
can call function which can sleep.
Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/btmrvl_main.c