A significant number of our tests in C accidentally use functions
authorAaron Ballman <aaron@aaronballman.com>
Sun, 13 Feb 2022 13:02:46 +0000 (08:02 -0500)
committerAaron Ballman <aaron@aaronballman.com>
Sun, 13 Feb 2022 13:03:40 +0000 (08:03 -0500)
commit1ea584377e7897f7df5302ed9cd378d17be14fbf
treed335e42d623bb92177d849b7d29f8c1727567e1d
parentd462e647542dc54718a4a4dfa6476b3dd2649a13
A significant number of our tests in C accidentally use functions
without prototypes. This patch converts the function signatures to have
a prototype for the situations where the test is not specific to K&R C
declarations. e.g.,

  void func();

becomes

  void func(void);

This is the ninth batch of tests being updated (there are a
significant number of other tests left to be updated).
365 files changed:
clang/test/Analysis/Inputs/expected-plists/unix-fns.c.plist
clang/test/Analysis/exploded-graph-rewriter/escapes.c
clang/test/Analysis/exploded-graph-rewriter/macros.c
clang/test/Analysis/expr-inspection-printState-diseq-info.c
clang/test/Analysis/expr-inspection-printState-eq-classes.c
clang/test/Analysis/expr-inspection.c
clang/test/Analysis/fields.c
clang/test/Analysis/flexible-array-members.c
clang/test/Analysis/flexignore.c
clang/test/Analysis/free.c
clang/test/Analysis/fuchsia_lock.c
clang/test/Analysis/fuchsia_lock_impl.c
clang/test/Analysis/func.c
clang/test/Analysis/gcdantipatternchecker_test.m
clang/test/Analysis/generics.m
clang/test/Analysis/global-region-invalidation.c
clang/test/Analysis/gmalloc.c
clang/test/Analysis/hangs.c
clang/test/Analysis/html-diag-singlefile.c
clang/test/Analysis/html-diag-singlefile.h
clang/test/Analysis/html-diags-analyze-headers.h
clang/test/Analysis/html-diags-multifile.c
clang/test/Analysis/html-diags.c
clang/test/Analysis/html_diagnostics/relevant_lines/notexecutedlines.c
clang/test/Analysis/html_diagnostics/td-hotfix.c
clang/test/Analysis/html_diagnostics/variable-popups-macro.c
clang/test/Analysis/html_diagnostics/variable-popups-multiple.c
clang/test/Analysis/html_diagnostics/variable-popups-simple.c
clang/test/Analysis/index-type.c
clang/test/Analysis/initialization.c
clang/test/Analysis/inline-not-supported.c
clang/test/Analysis/inline-plist.c
clang/test/Analysis/inline-unique-reports.c
clang/test/Analysis/inline.c
clang/test/Analysis/inline2.c
clang/test/Analysis/inline3.c
clang/test/Analysis/inlining/InlineObjCClassMethod.m
clang/test/Analysis/inlining/InlineObjCInstanceMethod.m
clang/test/Analysis/inlining/ObjCDynTypePopagation.m
clang/test/Analysis/inlining/RetainCountExamples.m
clang/test/Analysis/inlining/analysis-order.c
clang/test/Analysis/inlining/eager-reclamation-path-notes.c
clang/test/Analysis/inlining/false-positive-suppression.c
clang/test/Analysis/inlining/false-positive-suppression.m
clang/test/Analysis/inlining/inline-defensive-checks.m
clang/test/Analysis/inlining/path-notes.c
clang/test/Analysis/inlining/path-notes.m
clang/test/Analysis/inlining/test-always-inline-size-option.c
clang/test/Analysis/invalid-a-na-ly-zer-con-fig-value.c
clang/test/Analysis/invalid-analyzer-config-value.c
clang/test/Analysis/invalid-checker-option.c
clang/test/Analysis/invalid-deref.c
clang/test/Analysis/ivars.m
clang/test/Analysis/keychainAPI-diagnostic-visitor.m
clang/test/Analysis/keychainAPI.m
clang/test/Analysis/kmalloc-linux.c
clang/test/Analysis/live-variables.m
clang/test/Analysis/localization-aggressive.m
clang/test/Analysis/localization.m
clang/test/Analysis/logical-ops.c
clang/test/Analysis/loop-block-counts.c
clang/test/Analysis/loop-widening.c
clang/test/Analysis/main.c
clang/test/Analysis/malloc-annotations.c
clang/test/Analysis/malloc-custom.c
clang/test/Analysis/malloc-fnptr-plist.c
clang/test/Analysis/malloc-interprocedural.c
clang/test/Analysis/malloc-overflow.c
clang/test/Analysis/malloc-plist.c
clang/test/Analysis/malloc-protoype.c
clang/test/Analysis/malloc-sizeof.c
clang/test/Analysis/malloc-three-arg.c
clang/test/Analysis/malloc.c
clang/test/Analysis/malloc.m
clang/test/Analysis/max-nodes-suppress-on-sink.c
clang/test/Analysis/misc-ps-arm.m
clang/test/Analysis/misc-ps-eager-assume.m
clang/test/Analysis/misc-ps-region-store-i386.m
clang/test/Analysis/misc-ps-region-store-x86_64.m
clang/test/Analysis/misc-ps-region-store.m
clang/test/Analysis/misc-ps.c
clang/test/Analysis/misc-ps.m
clang/test/Analysis/mmap-writeexec.c
clang/test/Analysis/nil-receiver-undefined-larger-than-voidptr-ret.m
clang/test/Analysis/no-outofbounds.c
clang/test/Analysis/non-diagnosable-assumptions.c
clang/test/Analysis/nonnull.m
clang/test/Analysis/null-deref-path-notes.c
clang/test/Analysis/null-deref-path-notes.m
clang/test/Analysis/null-deref-ps-region.c
clang/test/Analysis/null-deref-ps.c
clang/test/Analysis/null-deref-static.m
clang/test/Analysis/nullability.m
clang/test/Analysis/objc-arc.m
clang/test/Analysis/objc-bool.m
clang/test/Analysis/objc-boxing.m
clang/test/Analysis/objc-for.m
clang/test/Analysis/objc-indirect-copy-restore.m
clang/test/Analysis/objc-message.m
clang/test/Analysis/objc-method-coverage.m
clang/test/Analysis/objc-radar17039661.m
clang/test/Analysis/offsetofexpr-callback.c
clang/test/Analysis/openmp-unsupported.c
clang/test/Analysis/out-of-bounds-false-positive.c
clang/test/Analysis/out-of-bounds.c
clang/test/Analysis/outofbound.c
clang/test/Analysis/padding_c.c
clang/test/Analysis/plist-html-macros.c
clang/test/Analysis/plist-macros-with-expansion-ctu.c
clang/test/Analysis/plist-macros-with-expansion.c
clang/test/Analysis/plist-output-alternate.m
clang/test/Analysis/plist-output.m
clang/test/Analysis/plist-stats-output.c
clang/test/Analysis/pointer-arithmetic.c
clang/test/Analysis/pointer-escape-on-conservative-calls.c
clang/test/Analysis/pr22954.c
clang/test/Analysis/pr_4164.c
clang/test/Analysis/properties.m
clang/test/Analysis/pthreadlock_state.c
clang/test/Analysis/pthreadlock_state_nottracked.c
clang/test/Analysis/ptr-arith.c
clang/test/Analysis/range_casts.c
clang/test/Analysis/rdar-6600344-nil-receiver-undefined-struct-ret.m
clang/test/Analysis/redefined_system.c
clang/test/Analysis/region-store.c
clang/test/Analysis/retain-release-arc.m
clang/test/Analysis/retain-release-cf-audited.m
clang/test/Analysis/retain-release-compound-literal.m
clang/test/Analysis/retain-release-inline.m
clang/test/Analysis/retain-release-path-notes.m
clang/test/Analysis/retain-release-region-store.m
clang/test/Analysis/retain-release-safe.c
clang/test/Analysis/retain-release.m
clang/test/Analysis/security-syntax-checks-no-emit.c
clang/test/Analysis/security-syntax-checks.m
clang/test/Analysis/simple-stream-checks.c
clang/test/Analysis/solver-sym-simplification-adjustment.c
clang/test/Analysis/solver-sym-simplification-concreteint.c
clang/test/Analysis/solver-sym-simplification-no-crash2.c
clang/test/Analysis/solver-sym-simplification-with-proper-range-type.c
clang/test/Analysis/stack-addr-ps.c
clang/test/Analysis/stackaddrleak.c
clang/test/Analysis/static_local.m
clang/test/Analysis/stats.c
clang/test/Analysis/std-c-library-functions-POSIX-lookup.c
clang/test/Analysis/std-c-library-functions-POSIX.c
clang/test/Analysis/std-c-library-functions-arg-constraints-tracking-notes.c
clang/test/Analysis/std-c-library-functions-arg-constraints.c
clang/test/Analysis/std-c-library-functions-arg-weakdeps.c
clang/test/Analysis/std-c-library-functions-lookup.c
clang/test/Analysis/std-c-library-functions-restrict.c
clang/test/Analysis/std-c-library-functions.c
clang/test/Analysis/stream-error.c
clang/test/Analysis/stream-note.c
clang/test/Analysis/stream.c
clang/test/Analysis/string-with-signedness.c
clang/test/Analysis/string.c
clang/test/Analysis/sval-dump-int128.c
clang/test/Analysis/svalbuilder-float-cast.c
clang/test/Analysis/svalbuilder-logic.c
clang/test/Analysis/svalbuilder-rearrange-comparisons.c
clang/test/Analysis/switch-case.c
clang/test/Analysis/symbol-reaper.c
clang/test/Analysis/taint-diagnostic-visitor.c
clang/test/Analysis/taint-dumps.c
clang/test/Analysis/taint-generic.c
clang/test/Analysis/taint-tester.c
clang/test/Analysis/test-after-div-zero.c
clang/test/Analysis/test-include.c
clang/test/Analysis/track-control-dependency-conditions.m
clang/test/Analysis/transparent_union_bug.c
clang/test/Analysis/traversal-begin-end-function.c
clang/test/Analysis/traversal-path-unification.c
clang/test/Analysis/trustnonnullchecker_test.m
clang/test/Analysis/undef-buffers.c
clang/test/Analysis/undef-call.c
clang/test/Analysis/uninit-bug-first-iteration-init.c
clang/test/Analysis/uninit-const.c
clang/test/Analysis/uninit-exhaustive-switch-bug.c
clang/test/Analysis/uninit-vals-union.c
clang/test/Analysis/uninit-vals.c
clang/test/Analysis/uninit-vals.m
clang/test/Analysis/unix-fns.c
clang/test/Analysis/unreachable-code-path.c
clang/test/Analysis/unused-ivars.m
clang/test/Analysis/vector.m
clang/test/Analysis/vfork.c
clang/test/Analysis/vla-overflow.c
clang/test/Analysis/vla.c
clang/test/Analysis/weak-functions.c
clang/test/Analysis/yaccignore.c
clang/test/Analysis/z3/apsint.c
clang/test/CodeGen/2002-01-24-ComplexSpaceInType.c
clang/test/CodeGen/2002-02-13-TypeVarNameCollision.c
clang/test/CodeGen/2002-02-13-UnnamedLocal.c
clang/test/CodeGen/2002-02-17-ArgumentAddress.c
clang/test/CodeGen/2002-02-18-64bitConstant.c
clang/test/CodeGen/2002-03-14-BrokenSSA.c
clang/test/CodeGen/2002-03-14-QuotesInStrConst.c
clang/test/CodeGen/2002-04-07-SwitchStmt.c
clang/test/CodeGen/2002-05-23-StaticValues.c
clang/test/CodeGen/2002-06-25-FWriteInterfaceFailure.c
clang/test/CodeGen/2002-07-14-MiscListTests.c
clang/test/CodeGen/2002-07-17-StringConstant.c
clang/test/CodeGen/2002-07-30-SubregSetAssertion.c
clang/test/CodeGen/2002-07-30-VarArgsCallFailure.c
clang/test/CodeGen/2002-07-31-SubregFailure.c
clang/test/CodeGen/2002-08-02-UnionTest.c
clang/test/CodeGen/2002-09-19-StarInLabel.c
clang/test/CodeGen/2002-10-12-TooManyArguments.c
clang/test/CodeGen/2002-12-15-StructParameters.c
clang/test/CodeGen/2003-06-26-CFECrash.c
clang/test/CodeGen/2003-06-29-MultipleFunctionDefinition.c
clang/test/CodeGen/2003-08-18-SigSetJmp.c
clang/test/CodeGen/2003-08-20-BadBitfieldRef.c
clang/test/CodeGen/2003-08-20-PrototypeMismatch.c
clang/test/CodeGen/2003-08-21-BinOp-Type-Mismatch.c
clang/test/CodeGen/2003-08-21-StmtExpr.c
clang/test/CodeGen/2003-08-29-BitFieldStruct.c
clang/test/CodeGen/2003-08-29-HugeCharConst.c
clang/test/CodeGen/2003-10-29-AsmRename.c
clang/test/CodeGen/2003-11-01-EmptyStructCrash.c
clang/test/CodeGen/2003-11-16-StaticArrayInit.c
clang/test/CodeGen/2003-11-20-ComplexDivision.c
clang/test/CodeGen/2003-11-20-UnionBitfield.c
clang/test/CodeGen/2003-12-14-ExternInlineSupport.c
clang/test/CodeGen/2004-02-12-LargeAggregateCopy.c
clang/test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c
clang/test/CodeGen/2004-03-07-ExternalConstant.c
clang/test/CodeGen/2004-03-15-SimpleIndirectGoto.c
clang/test/CodeGen/2004-03-16-AsmRegisterCrash.c
clang/test/CodeGen/2004-06-08-OpaqueStructArg.c
clang/test/CodeGen/2004-11-27-StaticFunctionRedeclare.c
clang/test/CodeGen/2005-01-02-ConstantInits.c
clang/test/CodeGen/2005-02-27-MarkGlobalConstant.c
clang/test/CodeGen/2005-03-06-OffsetOfStructCrash.c
clang/test/CodeGen/2005-06-15-ExpandGotoInternalProblem.c
clang/test/CodeGen/2005-07-28-IncorrectWeakGlobal.c
clang/test/CodeGen/2005-09-24-AsmUserPrefix.c
clang/test/CodeGen/2005-12-04-AttributeUsed.c
clang/test/CodeGen/2006-01-13-Includes.c
clang/test/CodeGen/2006-03-03-MissingInitializer.c
clang/test/CodeGen/2006-05-19-SingleEltReturn.c
clang/test/CodeGen/2006-09-28-SimpleAsm.c
clang/test/CodeGen/2006-10-30-ArrayCrash.c
clang/test/CodeGen/2007-01-24-InlineAsmCModifier.c
clang/test/CodeGen/2007-02-07-AddrLabel.c
clang/test/CodeGen/2007-04-05-PackedBitFields-2.c
clang/test/CodeGen/2007-04-05-PackedBitFields.c
clang/test/CodeGen/2007-04-05-PackedStruct.c
clang/test/CodeGen/2007-04-05-UnPackedStruct.c
clang/test/CodeGen/2007-04-11-InlineAsmStruct.c
clang/test/CodeGen/2007-04-11-InlineAsmUnion.c
clang/test/CodeGen/2007-04-13-InlineAsmStruct2.c
clang/test/CodeGen/2007-04-13-InlineAsmUnion2.c
clang/test/CodeGen/2007-05-08-PCH.c
clang/test/CodeGen/2007-06-15-AnnotateAttribute.c
clang/test/CodeGen/2007-08-01-LoadStoreAlign.c
clang/test/CodeGen/2007-08-21-ComplexCst.c
clang/test/CodeGen/2007-09-05-ConstCtor.c
clang/test/CodeGen/2007-09-27-ComplexIntCompare.c
clang/test/CodeGen/2007-09-28-PackedUnionMember.c
clang/test/CodeGen/2007-10-30-Volatile.c
clang/test/CodeGen/2007-11-07-AlignedMemcpy.c
clang/test/CodeGen/2007-11-07-CopyAggregateAlign.c
clang/test/CodeGen/2007-11-07-ZeroAggregateAlign.c
clang/test/CodeGen/2007-12-16-AsmNoUnwind.c
clang/test/CodeGen/2008-01-21-PackedBitFields.c
clang/test/CodeGen/2008-02-26-inline-asm-bug.c
clang/test/CodeGen/2008-05-12-TempUsedBeforeDef.c
clang/test/CodeGen/2008-07-17-no-emit-on-error.c
clang/test/CodeGen/2008-07-21-mixed-var-fn-decl.c
clang/test/CodeGen/2008-07-22-packed-bitfield-access.c
clang/test/CodeGen/2008-07-29-override-alias-decl.c
clang/test/CodeGen/2008-07-30-implicit-initialization.c
clang/test/CodeGen/2008-07-30-redef-of-bitcasted-decl.c
clang/test/CodeGen/2008-07-31-asm-labels.c
clang/test/CodeGen/2008-07-31-promotion-of-compound-pointer-arithmetic.c
clang/test/CodeGen/2009-02-13-zerosize-union-field.c
clang/test/CodeGen/2009-03-13-dbg.c
clang/test/CodeGen/2009-04-23-dbg.c
clang/test/CodeGen/2009-05-22-callingconv.c
clang/test/CodeGen/2009-06-14-HighlyAligned.c
clang/test/CodeGen/2009-07-15-pad-wchar_t-array.c
clang/test/CodeGen/2009-07-31-DbgDeclare.c
clang/test/CodeGen/2009-10-20-GlobalDebug.c
clang/test/CodeGen/2010-02-10-PointerName.c
clang/test/CodeGen/2010-02-15-DbgStaticVar.c
clang/test/CodeGen/2010-02-16-DbgScopes.c
clang/test/CodeGen/2010-02-18-Dbg-VectorType.c
clang/test/CodeGen/2010-07-08-DeclDebugLineNo.c
clang/test/CodeGen/2010-08-10-DbgConstant.c
clang/test/CodeGen/OpaqueStruct.c
clang/test/CodeGen/PR2001-bitfield-reload.c
clang/test/CodeGen/PR2413-void-address-cast-error.c
clang/test/CodeGen/PR2643-null-store-to-bitfield.c
clang/test/CodeGen/PR2743-reference-missing-static.c
clang/test/CodeGen/PR32874.c
clang/test/CodeGen/PR3589-freestanding-libcalls.c
clang/test/CodeGen/PR3709-int-to-pointer-sign.c
clang/test/CodeGen/PowerPC/aix-constructor-attribute.c
clang/test/CodeGen/PowerPC/aix-destructor-attribute.c
clang/test/CodeGen/PowerPC/aix_alloca_align.c
clang/test/CodeGen/PowerPC/altivec.c
clang/test/CodeGen/PowerPC/builtins-ppc-p9-f128.c
clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-math.c
clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-stfiw.c
clang/test/CodeGen/PowerPC/ppc-sfvarargs.c
clang/test/CodeGen/PowerPC/ppc32-dwarf.c
clang/test/CodeGen/PowerPC/ppc64-dwarf.c
clang/test/CodeGen/PowerPC/ppc64-f128-builtins.c
clang/test/CodeGen/PowerPC/ppc64le-aggregates.c
clang/test/CodeGen/PowerPC/vector-bool-pixel-altivec-init-no-parentheses.c
clang/test/CodeGen/PowerPC/vector-bool-pixel-altivec-init.c
clang/test/CodeGen/RISCV/riscv-inline-asm.c
clang/test/CodeGen/RISCV/riscv-sdata-module-flag.c
clang/test/CodeGen/RISCV/riscv32-ilp32-ilp32f-ilp32d-abi.c
clang/test/CodeGen/RISCV/riscv32-ilp32d-abi.c
clang/test/CodeGen/RISCV/riscv32-ilp32f-abi.c
clang/test/CodeGen/RISCV/riscv32-ilp32f-ilp32d-abi.c
clang/test/CodeGen/RISCV/riscv64-lp64-abi.c
clang/test/CodeGen/RISCV/riscv64-lp64-lp64f-lp64d-abi.c
clang/test/CodeGen/RISCV/riscv64-lp64d-abi.c
clang/test/CodeGen/RISCV/riscv64-lp64f-lp64d-abi.c
clang/test/CodeGen/RISCV/rvv_errors.c
clang/test/CodeGen/SystemZ/s390x-packed-struct-func-arg.c
clang/test/CodeGen/SystemZ/systemz-inline-asm.c
clang/test/CodeGen/SystemZ/zos-alignment.c
clang/test/CodeGen/WebAssembly/wasm-arguments.c
clang/test/CodeGen/X86/avx-builtins.c
clang/test/CodeGen/X86/avx-union.c
clang/test/CodeGen/X86/avx512-inline-asm-kregisters-basics.c
clang/test/CodeGen/X86/avx512f-builtins.c
clang/test/CodeGen/X86/avx512fp16-abi.c
clang/test/CodeGen/X86/avx512fp16-builtins.c
clang/test/CodeGen/X86/cetintrin.c
clang/test/CodeGen/X86/fsgsbase-builtins.c
clang/test/CodeGen/X86/lwp-builtins.c
clang/test/CodeGen/X86/pause.c
clang/test/CodeGen/X86/pku.c
clang/test/CodeGen/X86/rd-builtins.c
clang/test/CodeGen/X86/sse-builtins.c
clang/test/CodeGen/X86/sse2-builtins.c
clang/test/CodeGen/X86/x86-64-inline-asm.c
clang/test/CodeGen/X86/x86-ssc-mark.c
clang/test/CodeGen/X86/x86-tsxldtrk-builtins.c
clang/test/CodeGen/X86/x86-uintr-builtins.c
clang/test/CodeGen/X86/x86-vector-width.c
clang/test/CodeGen/X86/x86.c
clang/test/CodeGen/X86/x86_32-arguments-darwin.c
clang/test/CodeGen/X86/x86_32-arguments-win32.c
clang/test/CodeGen/X86/x86_32-inline-asm.c
clang/test/CodeGen/X86/x86_32-xsave.c
clang/test/CodeGen/X86/x86_64-PR42672.c
clang/test/CodeGen/X86/x86_64-arguments-darwin.c
clang/test/CodeGen/X86/x86_64-arguments-nacl.c
clang/test/CodeGen/X86/x86_64-arguments-win32.c
clang/test/CodeGen/X86/x86_64-arguments.c
clang/test/CodeGen/X86/x86_64-mno-sse2.c
clang/test/CodeGen/X86/x86_64-xsave.c
clang/test/CodeGen/X86/x86_inlineasm_curly_bracket_escape.c
clang/test/CodeGenCXX/debug-info-composite-triviality-fwd-decl.cpp
clang/test/CodeGenCoroutines/coro-builtins-err.c
clang/test/CodeGenOpenCL/func-call-dbg-loc.cl
clang/test/CodeGenOpenCL/null_queue.cl