projects / platform / upstream / llvm.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cf2048b) | patch
[libc++] random_device fails if open returns zero
authorDavid Majnemer <david.majnemer@gmail.com>
Tue, 3 Jun 2014 02:21:37 +0000 (02:21 +0000)
committerDavid Majnemer <david.majnemer@gmail.com>
Tue, 3 Jun 2014 02:21:37 +0000 (02:21 +0000)
commit1e9592a9c71ed87c806946ad2cccc1bcb472324d
tree847dbc2f903eda47bd45c8abcce95ed631da1ab8tree | snapshot
parentcf2048bbb3c3340e676fa166b2afd68e9ebf4e8dcommit | diff
[libc++] random_device fails if open returns zero

random_device::random_device(const string&) wrongly assumes that open
can only validly return a file descriptor greater than zero.

This results in random_device believing that it didn't successfully open
the device causing it to throw in it's constructor, this ends up leaking
a file descriptor.

The fix is simple, don't error on file descriptors which are zero.

llvm-svn: 210060
libcxx/src/random.cpp diff | blob | history
libcxx/test/numerics/rand/rand.device/ctor.pass.cpp diff | blob | history
Domain: System / Toolchain;