[InlineAsm] Remove EarlyClobber on registers that are also inputs
authorHal Finkel <hfinkel@anl.gov>
Mon, 20 Apr 2015 00:01:30 +0000 (00:01 +0000)
committerHal Finkel <hfinkel@anl.gov>
Mon, 20 Apr 2015 00:01:30 +0000 (00:01 +0000)
commit1e5733bbed76e5fc56db3c3c23262e5bc2b1c82f
treef2b5d081f4493e485ff3b82fa5b0270e4df54504
parent3d9e582a46f01dcd2089cc50e989940f3e139740
[InlineAsm] Remove EarlyClobber on registers that are also inputs

When an inline asm call has an output register marked as early-clobber, but
that same register is also an input operand, what should we do? GCC accepts
this, and is documented to accept this for read/write operands saying,
"Furthermore, if the earlyclobber operand is also a read/write operand, then
that operand is written only after it's used." For write-only operands, the
situation seems less clear, but I have at least one existing codebase that
assumes this will work, in part because it has syscall macros like this:

({                                                                         \
  register uint64_t r0 __asm__ ("r0") = (__NR_ ## name);                   \
  register uint64_t r3 __asm__ ("r3") = ((uint64_t) (arg0));               \
  register uint64_t r4 __asm__ ("r4") = ((uint64_t) (arg1));               \
  register uint64_t r5 __asm__ ("r5") = ((uint64_t) (arg2));               \
  __asm__ __volatile__                                                     \
  ("sc"                                                                    \
   : "=&r"(r0),"=&r"(r3),"=&r"(r4),"=&r"(r5)                               \
   :   "0"(r0),  "1"(r3),  "2"(r4),  "3"(r5)                               \
   : "r6","r7","r8","r9","r10","r11","r12","cr0","memory");                \
  r3;                                                                      \
})

Furthermore, with register aliases and subregister relationships that only the
backend knows about, rejecting this in the frontend seems like a difficult
proposition (if we wanted to do so). However, keeping the early-clobber flag on
the INLINEASM MI does not work for us, because it will cause the register's
live interval to end to soon (so it will not appear defined to be used as an
input).

Fortunately, fixing this does not seem hard: When forming the INLINEASM MI,
check to see if any of the early-clobber outputs are also inputs, and if so,
remove the early-clobber flag.

llvm-svn: 235283
llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp
llvm/test/CodeGen/PowerPC/ec-input.ll [new file with mode: 0644]