ARM: OMAP2+: Fix null pointer dereference and memory leak in omap_soc_device_init
authorKunwu Chan <chentao@kylinos.cn>
Thu, 23 Nov 2023 14:52:37 +0000 (22:52 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jan 2024 12:42:26 +0000 (12:42 +0000)
commit1e4f9b7abf54801e70350149d561c03d72966698
treeb684ba24401a66165e3073a88b504d60c196e48e
parentbc9ca01ef814faf91deca5e658932f7d6f9589c8
ARM: OMAP2+: Fix null pointer dereference and memory leak in omap_soc_device_init

[ Upstream commit c72b9c33ef9695ad7ce7a6eb39a9df8a01b70796 ]

kasprintf() returns a pointer to dynamically allocated memory which can
be NULL upon failure. When 'soc_dev_attr->family' is NULL,it'll trigger
the null pointer dereference issue, such as in 'soc_info_show'.

And when 'soc_device_register' fails, it's necessary to release
'soc_dev_attr->family' to avoid memory leaks.

Fixes: 6770b2114325 ("ARM: OMAP2+: Export SoC information to userspace")
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Message-ID: <20231123145237.609442-1-chentao@kylinos.cn>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/mach-omap2/id.c