Avoid race condition when handling a SIGWINCH signal
authorPatrick Palka <patrick@parcs.ath.cx>
Tue, 28 Apr 2015 01:37:48 +0000 (21:37 -0400)
committerPatrick Palka <patrick@parcs.ath.cx>
Wed, 13 May 2015 15:53:28 +0000 (11:53 -0400)
commit1e04046d0b7e0f87bc6e2fefd966c9dd89d2ce13
treefec0ac237bd87cc93603dc18cad9fac8704fcd7e
parent558e5469679897ee57ad6706074f55ff4952cf43
Avoid race condition when handling a SIGWINCH signal

The control variable win_resized must be cleared before responding to
it.

Otherwise there is a small window where another SIGWINCH might occur in
between the handling of an earlier SIGWINCH and the clearing of
win_resized, at which point win_resized would be set (again) by the
signal handler.  Shortly thereafter we would clear win_resized even
though we only handled the earlier SIGWINCH but not the latest one.
This chain of events is all avoided if we clear win_resized first.

gdb/ChangeLog:

* tui/tui-win.c (tui_async_resize_screen): Clear win_resized
first before resizing the window.
* tui.c (tui_enable): Likewise.
gdb/tui/tui-win.c
gdb/tui/tui.c