core-util: Use _SC_NPROCESSORS_ONLN instead of _SC_NPROCESSORS_CONF
authorJohn Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Mon, 4 Jul 2016 18:23:17 +0000 (20:23 +0200)
committerTanu Kaskinen <tanuk@iki.fi>
Mon, 15 Aug 2016 14:23:36 +0000 (17:23 +0300)
commit1df21e6ab6cd42e2f7601a6c5577c20b7e3d1046
tree4924a717e6d783b6847c36cd7d33458fd73110c7
parent9e4ee38c17dfe81da2c7e40b18f3d47f8a55be80
core-util: Use _SC_NPROCESSORS_ONLN instead of _SC_NPROCESSORS_CONF

pa_ncpu() is supposed to report the number of processors available on
the system. For that, it currently calls sysconf(_SC_NPROCESSORS_CONF).
However, since the operating system can disable individual processors,
we should call sysconf(_SC_NPROCESSORS_ONLN) to determine the number
of processors currently available [1]. Consequently, the once-test will
fail since pthread_setaffinity_np() is called with CPUs that are
currently not available.

It might also be advisable to change the code in the future to use CPU
sets on Linux as even the suggested change is not 100% safe but at least
it improves over the existing code. If PulseAudio was to be run in a CPU
set [2], the number of processors available to PulseAudio could be even
less than the number of CPUs currently online (_SC_NPROCESSORS_CONF).

[1] https://www.gnu.org/software/libc/manual/html_node/Processor-Resources.html
[2] http://man7.org/linux/man-pages/man7/cpuset.7.html

BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=96809
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
src/pulsecore/core-util.c