media: v4l2-core: only zero-out ioctl-read buffers
authorArnd Bergmann <arnd@arndb.de>
Wed, 8 Jan 2020 10:00:00 +0000 (11:00 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 8 Jan 2020 12:27:58 +0000 (13:27 +0100)
commit1dc8b65c944e5cfce3d830a5b97b42be185a1984
treeef39a9c754f0f74fc9efab6e598b52dbe1b44945
parente4b9b6454d94481483c435b94517249b79e82b63
media: v4l2-core: only zero-out ioctl-read buffers

The memset() got moved out of the check for _IOC_NONE, so passing a
made-up command number with a size but no direction would allow clearing
data on user-provided pointers.

Move video_get_user() back into the _IOC_NONE check where it belongs.

Reported-by: syzbot+54fd8cca4b7226c94b8e@syzkaller.appspotmail.com
Fixes: 6c625c01c7a6 ("media: v4l2-core: split out data copy from video_usercopy")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/v4l2-core/v4l2-ioctl.c