f2fs: fix to avoid race in between atomic write and background GC
authorChao Yu <yuchao0@huawei.com>
Tue, 27 Feb 2018 14:45:24 +0000 (22:45 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Mon, 12 Mar 2018 23:05:55 +0000 (08:05 +0900)
commit1dc0f8991d4d93194fb7a3ac3164e05e8b24ad02
treeee8b325d2471bfce3120d5eb211a6b9587453f84
parentb27bc8091ccf22f66ab105d10fa4f5cdeaef05a2
f2fs: fix to avoid race in between atomic write and background GC

Sqlite user Background GC
- move_data_block
  : move page #1
 - f2fs_is_atomic_file
- f2fs_ioc_start_atomic_write
- f2fs_ioc_commit_atomic_write
 - commit_inmem_pages
   : commit page #1 & set node #2 dirty
 - f2fs_submit_page_write
  - f2fs_update_data_blkaddr
   - set_page_dirty
     : set node #2 dirty
 - f2fs_do_sync_file
  - fsync_node_pages
   : commit node #1 & node #2, then sudden power-cut

In a race case, we may check FI_ATOMIC_FILE flag before starting atomic
write flow, then we will commit meta data before data with reversed
order, after a sudden pow-cut, database transaction will be inconsistent.

So we'd better to exclude gc/atomic_write to each other by using lock
instead of flag checking.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c