bpf: Fix cgroup ref leak in cgroup_bpf_inherit on out-of-memory
authorAndrii Nakryiko <andriin@fb.com>
Mon, 9 Mar 2020 22:40:17 +0000 (15:40 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Tue, 10 Mar 2020 02:58:54 +0000 (19:58 -0700)
commit1d8006abaab4cb90f81add86e8d1bf9411add05a
treeb6dd24074e513d6fb9845dbfe28b30f2c7dcd671
parent62039c30c19dcab96621e074aeeb90da7100def7
bpf: Fix cgroup ref leak in cgroup_bpf_inherit on out-of-memory

There is no compensating cgroup_bpf_put() for each ancestor cgroup in
cgroup_bpf_inherit(). If compute_effective_progs returns error, those cgroups
won't be freed ever. Fix it by putting them in cleanup code path.

Fixes: e10360f815ca ("bpf: cgroup: prevent out-of-order release of cgroup bpf")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Roman Gushchin <guro@fb.com>
Link: https://lore.kernel.org/bpf/20200309224017.1063297-1-andriin@fb.com
kernel/bpf/cgroup.c