docs: kernel_abi.py: fix command injection
authorVegard Nossum <vegard.nossum@oracle.com>
Sun, 31 Dec 2023 23:59:59 +0000 (00:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Feb 2024 00:18:54 +0000 (16:18 -0800)
commit1d64a1029884f7bfbf00f5c04f7ef04a437fe8a4
tree84b9ac33ade070b09b241e3ebb3f1927f8dcaea1
parentc018ab3e31b16ff97b9b95b69904104c9fcca95b
docs: kernel_abi.py: fix command injection

commit 3231dd5862779c2e15633c96133a53205ad660ce upstream.

The kernel-abi directive passes its argument straight to the shell.
This is unfortunate and unnecessary.

Let's always use paths relative to $srctree/Documentation/ and use
subprocess.check_call() instead of subprocess.Popen(shell=True).

This also makes the code shorter.

Link: https://fosstodon.org/@jani/111676532203641247
Reported-by: Jani Nikula <jani.nikula@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Link: https://lore.kernel.org/r/20231231235959.3342928-2-vegard.nossum@oracle.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Documentation/admin-guide/abi-obsolete.rst
Documentation/admin-guide/abi-removed.rst
Documentation/admin-guide/abi-stable.rst
Documentation/admin-guide/abi-testing.rst
Documentation/sphinx/kernel_abi.py