nfsd: fix error handling of register_pernet_subsys() in init_nfsd()
authorPatrick Ho <Patrick.Ho@netapp.com>
Sat, 21 Aug 2021 06:56:26 +0000 (02:56 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Thu, 30 Sep 2021 14:58:52 +0000 (10:58 -0400)
commit1d625050c7c2dd877e108e382b8aaf1ae3cfe1f4
treefb7ee0160c5035a2ea424b9e27bb1529f9191311
parent02579b2ff8b0becfb51d85a975908ac4ab15fba8
nfsd: fix error handling of register_pernet_subsys() in init_nfsd()

init_nfsd() should not unregister pernet subsys if the register fails
but should instead unwind from the last successful operation which is
register_filesystem().

Unregistering a failed register_pernet_subsys() call can result in
a kernel GPF as revealed by programmatically injecting an error in
register_pernet_subsys().

Verified the fix handled failure gracefully with no lingering nfsd
entry in /proc/filesystems.  This change was introduced by the commit
bd5ae9288d64 ("nfsd: register pernet ops last, unregister first"),
the original error handling logic was correct.

Fixes: bd5ae9288d64 ("nfsd: register pernet ops last, unregister first")
Cc: stable@vger.kernel.org
Signed-off-by: Patrick Ho <Patrick.Ho@netapp.com>
Acked-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfsctl.c