Bluetooth: af_bluetooth: Fix Use-After-Free in bt_sock_recvmsg
authorHyunwoo Kim <v4bel@theori.io>
Sat, 9 Dec 2023 10:55:18 +0000 (05:55 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jan 2024 12:42:40 +0000 (12:42 +0000)
commit1d576c3a5af850bf11fbd103f9ba11aa6d6061fb
tree11a2ce77948069f6ed7d8660b4b81778fb3a3e07
parent90d6a3974771395cebc8d97e8ec69d5444f65d5d
Bluetooth: af_bluetooth: Fix Use-After-Free in bt_sock_recvmsg

commit 2e07e8348ea454615e268222ae3fc240421be768 upstream.

This can cause a race with bt_sock_ioctl() because
bt_sock_recvmsg() gets the skb from sk->sk_receive_queue
and then frees it without holding lock_sock.
A use-after-free for a skb occurs with the following flow.
```
bt_sock_recvmsg() -> skb_recv_datagram() -> skb_free_datagram()
bt_sock_ioctl() -> skb_peek()
```
Add lock_sock to bt_sock_recvmsg() to fix this issue.

Cc: stable@vger.kernel.org
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/bluetooth/af_bluetooth.c