[clang-tools-extra] fix the check for if '-latomic' is necessary
authorGokturk Yuksek <gokturk@binghamton.edu>
Fri, 14 Feb 2020 14:12:45 +0000 (14:12 +0000)
committerLuís Marques <luismarques@lowrisc.org>
Fri, 14 Feb 2020 14:16:10 +0000 (14:16 +0000)
commit1d40c4150630729a9c1ce5119a8027dac93a5b2d
treee34bb887f860037aa0b95dee21f8f3ecc14589e4
parent9816e726e747d72e0c5ac92aa20e652031a10448
[clang-tools-extra] fix the check for if '-latomic' is necessary

Summary:
The CheckAtomic module performs two tests to determine if passing
'-latomic' to the linker is required: one for 64-bit atomics, and
another for non-64-bit atomics. clangd only uses the result from
HAVE_CXX_ATOMICS64_WITHOUT_LIB. This is incomplete because there are
uses of non-64-bit atomics in the code, such as the ReplyOnce::Replied
of type std::atomic<bool> defined in clangd/ClangdLSPServer.cpp.

Fix by also checking for the result of HAVE_CXX_ATOMICS_WITHOUT_LIB.

See also: https://reviews.llvm.org/D68964

Reviewers: ilya-biryukov, nridge, kadircet, beanz, compnerd, luismarques
Reviewed By: luismarques
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69869
clang-tools-extra/clangd/CMakeLists.txt