ASoC: xlnx: fix error handling in xlnx_formatter_pcm_probe
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 26 Dec 2018 21:11:06 +0000 (15:11 -0600)
committerMark Brown <broonie@kernel.org>
Thu, 3 Jan 2019 16:34:37 +0000 (16:34 +0000)
commit1d38b4e903d577f05393eb0ac6727f40d90dd6c6
tree5d7b12c82a1f85cb7b63b9bb7d400b39ec57fa8d
parentf5758544d98c8bec7793aeea28928f5e8bd45d47
ASoC: xlnx: fix error handling in xlnx_formatter_pcm_probe

Currently, if platform_get_irq_byname() fails, the returned error
turns into a huge value, once it is being store into a variable
of type unsigned int, hence never actually reporting any error
and causing unexpected behavior when using the values stored
in aud_drv_data->s2mm_irq and aud_drv_data->mm2s_irq.

Fix this by changing the type of variables s2mm_irq and mm2s_irq in
structure xlnx_pcm_drv_data from unsigned int to int.

Addresses-Coverity-ID: 1476096 ("Unsigned compared against 0")
Fixes: 796175a94a7f ("ASoC: xlnx: add pcm formatter platform driver")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/xilinx/xlnx_formatter_pcm.c