iscsi-target: Drop duplicate __iscsi_target_login_thread check
authorNicholas Bellinger <nab@linux-iscsi.org>
Wed, 17 Sep 2014 20:17:55 +0000 (13:17 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 17 Sep 2014 20:33:14 +0000 (13:33 -0700)
commit1d30686da4a40029cb48eab28442896b58aeceef
tree0478a7167324ad6e93fd514a57c1deb75e31425e
parent5c22e2294156377b7e2d2d99aaffea9ae6994452
iscsi-target: Drop duplicate __iscsi_target_login_thread check

This patch drops the now duplicate + unnecessary check for -ENODEV from
iscsi_transport->iscsit_accept_np() for jumping to out:, or immediately
returning 1 in __iscsi_target_login_thread() code.

Since commit 81a9c5e72b the jump to out: and returning 1 have the same
effect, and end up hitting the ISCSI_NP_THREAD_SHUTDOWN check regardless
at the top of __iscsi_target_login_thread() during next loop iteration.

So that said, it's safe to go ahead and remove this duplicate check.

Reported-by: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_login.c