[media] cx18: struct i2c_client is too big for stack
authorMauro Carvalho Chehab <m.chehab@samsung.com>
Fri, 1 Nov 2013 16:09:47 +0000 (13:09 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Thu, 7 Nov 2013 17:04:00 +0000 (15:04 -0200)
commit1d212cf0c2d89adf3d0a6d62d729076f49f087dc
treed324859ec7a1269c995f7e6945a8cda129b7c6be
parent51d8e7fbffe34dc1c75ad28b49d0bcd210792424
[media] cx18: struct i2c_client is too big for stack

drivers/media/pci/cx18/cx18-driver.c: In function 'cx18_read_eeprom':
drivers/media/pci/cx18/cx18-driver.c:357:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]
That happens because the routine allocates 256 bytes for an eeprom buffer, plus
the size of struct i2c_client, with is big.
Change the logic to dynamically allocate/deallocate space for struct i2c_client,
instead of  using the stack.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/pci/cx18/cx18-driver.c