ipv4: prevent potential spectre v1 gadget in ip_metrics_convert()
authorEric Dumazet <edumazet@google.com>
Fri, 20 Jan 2023 13:30:40 +0000 (13:30 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 24 Jan 2023 05:37:25 +0000 (21:37 -0800)
commit1d1d63b612801b3f0a39b7d4467cad0abd60e5c8
tree87f21e16483d19ff80e3de39b4be7246afe530fc
parentd6ab640c21ed3b471e42ea783223c396e102c02d
ipv4: prevent potential spectre v1 gadget in ip_metrics_convert()

if (!type)
continue;
if (type > RTAX_MAX)
return -EINVAL;
...
metrics[type - 1] = val;

@type being used as an array index, we need to prevent
cpu speculation or risk leaking kernel memory content.

Fixes: 6cf9dfd3bd62 ("net: fib: move metrics parsing to a helper")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230120133040.3623463-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/metrics.c