net: warn if gso_type isn't set for a GSO SKB
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 20 Nov 2020 23:22:20 +0000 (00:22 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 24 Nov 2020 22:02:10 +0000 (14:02 -0800)
commit1d155dfdf50efc2b0793bce93c06d1a5b23d0877
tree9b57d9d172a7a2d073c6b46fb15213c85c80d1a8
parentbe419fcacf251423afc530b8964a355eb96e4040
net: warn if gso_type isn't set for a GSO SKB

In bug report [0] a warning in r8169 driver was reported that was
caused by an invalid GSO SKB (gso_type was 0). See [1] for a discussion
about this issue. Still the origin of the invalid GSO SKB isn't clear.

It shouldn't be a network drivers task to check for invalid GSO SKB's.
Also, even if issue [0] can be fixed, we can't be sure that a
similar issue doesn't pop up again at another place.
Therefore let gso_features_check() check for such invalid GSO SKB's.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=209423
[1] https://www.spinics.net/lists/netdev/msg690794.html

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/97c78d21-7f0b-d843-df17-3589f224d2cf@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/dev.c