ALSA: ymfpci: Fix the missing snd_card_free() call at probe error
authorTakashi Iwai <tiwai@suse.de>
Wed, 23 Aug 2023 16:16:25 +0000 (18:16 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 23 Aug 2023 16:17:33 +0000 (18:17 +0200)
commit1d0eb6143c1e85d3f9a3f5a616ee7e5dc351d33b
tree447b10b4f3d9a7ecfe16e8f2cfe4cb73366c14a2
parent46cdff2369cbdf8d78081a22526e77bd1323f563
ALSA: ymfpci: Fix the missing snd_card_free() call at probe error

Like a few other drivers, YMFPCI driver needs to clean up with
snd_card_free() call at an error path of the probe; otherwise the
other devres resources are released before the card and it results in
the UAF.

This patch uses the helper for handling the probe error gracefully.

Fixes: f33fc1576757 ("ALSA: ymfpci: Create card with device-managed snd_devm_card_new()")
Cc: <stable@vger.kernel.org>
Reported-and-tested-by: Takashi Yano <takashi.yano@nifty.ne.jp>
Closes: https://lore.kernel.org/r/20230823135846.1812-1-takashi.yano@nifty.ne.jp
Link: https://lore.kernel.org/r/20230823161625.5807-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/ymfpci/ymfpci.c