blk-wbt: introduce a new disable state to prevent false positive by rwb_enabled()
authorZhang Yi <yi.zhang@huawei.com>
Sat, 19 Jun 2021 09:36:59 +0000 (17:36 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 21 Jun 2021 21:03:41 +0000 (15:03 -0600)
commit1d0903d61e9645c6330b94247b96dd873dfc11c8
treea46e127deb8156f8a2390770c36d0a070a126749
parentfb926032b3209300f9dc454a36b8299582ae545c
blk-wbt: introduce a new disable state to prevent false positive by rwb_enabled()

Now that we disable wbt by simply zero out rwb->wb_normal in
wbt_disable_default() when switch elevator to bfq, but it's not safe
because it will become false positive if we change queue depth. If it
become false positive between wbt_wait() and wbt_track() when submit
write request, it will lead to drop rqw->inflight to -1 in wbt_done(),
which will end up trigger IO hung. Fix this issue by introduce a new
state which mean the wbt was disabled.

Fixes: a79050434b45 ("blk-rq-qos: refactor out common elements of blk-wbt")
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Link: https://lore.kernel.org/r/20210619093700.920393-2-yi.zhang@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-wbt.c
block/blk-wbt.h