ACPI: custom_method: fix a possible memory leak
authorMark Langsdorf <mlangsdo@redhat.com>
Tue, 27 Apr 2021 18:54:33 +0000 (13:54 -0500)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 28 Apr 2021 17:17:54 +0000 (19:17 +0200)
commit1cfd8956437f842836e8a066b40d1ec2fc01f13e
treee843fc6d6d26bd778bbe7529ffc0c3e115628f39
parente483bb9a991bdae29a0caa4b3a6d002c968f94aa
ACPI: custom_method: fix a possible memory leak

In cm_write(), if the 'buf' is allocated memory but not fully consumed,
it is possible to reallocate the buffer without freeing it by passing
'*ppos' as 0 on a subsequent call.

Add an explicit kfree() before kzalloc() to prevent the possible memory
leak.

Fixes: 526b4af47f44 ("ACPI: Split out custom_method functionality into an own driver")
Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
Cc: 5.4+ <stable@vger.kernel.org> # 5.4+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/custom_method.c